[
https://issues.apache.org/jira/browse/DRILL-7633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065559#comment-17065559
]
ASF GitHub Bot commented on DRILL-7633:
---------------------------------------
arina-ielchiieva commented on pull request #2018: DRILL-7633: Fixes for union
and repeated list accessors
URL: https://github.com/apache/drill/pull/2018#discussion_r397109336
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantColumnMetadata.java
##########
@@ -145,16 +147,28 @@ public ColumnMetadata cloneEmpty() {
@Override
public ColumnMetadata copy() {
- // TODO Auto-generated method stub
- assert false;
- return null;
+ return new VariantColumnMetadata(name, type, mode, variantSchema.copy());
}
@Override
public VariantMetadata variantSchema() {
return variantSchema;
}
+ @JsonProperty("type")
Review comment:
Remove json property annotation as it will be present in parent class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fixes for union and repeated list accessors
> -------------------------------------------
>
> Key: DRILL-7633
> URL: https://issues.apache.org/jira/browse/DRILL-7633
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.18.0
>
>
> Minor fixes for repeated list and Union type support in column accessors
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
