[
https://issues.apache.org/jira/browse/DRILL-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066703#comment-17066703
]
ASF GitHub Bot commented on DRILL-7663:
---------------------------------------
arina-ielchiieva commented on pull request #2039: DRILL-7663: Code refactor to
DefaultFunctionResolver
URL: https://github.com/apache/drill/pull/2039#discussion_r397879964
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/DefaultFunctionResolver.java
##########
@@ -38,12 +38,11 @@ public DrillFuncHolder getBestMatch(List<DrillFuncHolder>
methods, FunctionCall
int currcost = Integer.MAX_VALUE;
DrillFuncHolder bestmatch = null;
final List<DrillFuncHolder> bestMatchAlternatives = new LinkedList<>();
-
+ List<TypeProtos.MajorType> argumentTypes = Lists.newArrayList();
Review comment:
Well, it's just a suggestion... it's looks much better though.
If you want to leave as it you are welcome but then replace
`Lists.newArrayList();` Guava usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code refactor to DefaultFunctionResolver
> ----------------------------------------
>
> Key: DRILL-7663
> URL: https://issues.apache.org/jira/browse/DRILL-7663
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Weijie Tong
> Assignee: Weijie Tong
> Priority: Minor
> Fix For: 1.18.0
>
>
> A small code refactor to DefaultFunctionResolver
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
