[ 
https://issues.apache.org/jira/browse/DRILL-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070945#comment-17070945
 ] 

Bohdan Kazydub commented on DRILL-7677:
---------------------------------------

In the example UDF you are referencing there is a [nullability 
check|https://github.com/apache/drill/blob/master/contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java#L104]
 before calling the 
{{org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers.getStringFromVarCharHolder(input)}}
 to make sure this method is not invoked when {{input.isSet == 0}}. So no NPE 
is thrown, is it?
Could you provide an example of the issue you're having, please?

> NPE in getStringFromVarCharHolder(NullableVarCharHolder) 
> ---------------------------------------------------------
>
>                 Key: DRILL-7677
>                 URL: https://issues.apache.org/jira/browse/DRILL-7677
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Priority: Major
>
> Assume you have a function ([like this 
> one|https://github.com/apache/drill/blob/master/contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java#L110])
>  that has
> {code:java}
> @Param
> NullableVarCharHolder input;
> {code}
> and in the {code:java}eval(){code} function you do
> {code:java}String inputString = 
> org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers.getStringFromVarCharHolder(input);{code}
> When this function is called with the input actually being null the 'input' 
> parameter is an instance of NullableVarCharHolder where isSet is 0 and buffer 
> is null.
> The buffer being null causes an NPE in the call to 
> getStringFromVarCharHolder(NullableVarCharHolder)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to