[
https://issues.apache.org/jira/browse/DRILL-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082686#comment-17082686
]
ASF GitHub Bot commented on DRILL-7696:
---------------------------------------
paul-rogers commented on pull request #2051: DRILL-7696: EVF v2 scan schema
resolution
URL: https://github.com/apache/drill/pull/2051#discussion_r407743684
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantSchema.java
##########
@@ -215,4 +216,19 @@ public VariantSchema copy() {
}
return copy;
}
+
+ // Note: no hashCode() as these objects are not meant to be keys.
Review comment:
@arina-ielchiieva, thanks for the second review. I removed `equals()` and
went back to using the existing `isEquivalent()`, but with a revised
implementation. Since I could not use all the handy `Objects` plumbing for
`equals()`, I had to implement some custom stuff to do the same job. Reran all
tests to verify things still work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> EVF v2 Scan Schema Resolution
> -----------------------------
>
> Key: DRILL-7696
> URL: https://issues.apache.org/jira/browse/DRILL-7696
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.18.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> Revises the mechanism EVF uses to resolve the schema for a scan. See PR for
> details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
