[
https://issues.apache.org/jira/browse/DRILL-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Rogers updated DRILL-7697:
-------------------------------
Description:
Drill has two separate query editors:
* The one displayed from the Query tab
* The one displayed from the Edit Query tab within Profiles
The two editors do basically the same thing, but have evolved as copies that
have diverged.
* The Query tab editor places the three query types above the query text box,
while the Profiles version puts the same control below the query text box.
* The Query tab edit places the query types vertically, the provides version
horizontally.
* Similarly the Query tab editor puts the Ctrl+Enter hint above the text box,
Profiles puts it below.
* The Query tab provides a drop-down of available schemas, but the Profile tab
query editor does not.
A first request is to unify the two editors. In particular, move the code to a
common template file included in both places. PR #2052 used copy/paste to
narrow the gap. A better solution is to place the query editor in a shared
included template file.
Second, the Profiles editor is a bit redundant.
* Displays a "Cancel Query" button even if the query is completed. Hide this
button for completed queries. (Since there is a race condition, hide it for
queries completed at the time the page was created.)
* No need to ask the user for the query type. The profile includes the type
and the type should be a fixed field in Profiles.
* Similarly, the limit and (in Drill 1.18) the Default Schema should also be
recorded in the query plan and fixed. (The profile must change to include this
value.)
Since system/session options can affect a query, and are part of the query
plan, show those in the query as well so it can be rerun in the same
environment in which it originally ran.
Finally, since no one knows how to create a logical or physical plan, omit the
query type control altogether.
was:
Drill has two separate query editors:
* The one displayed from the Query tab
* The one displayed from the Edit Query tab within Profiles
The two editors do basically the same thing, but have evolved as copies that
have diverged.
* The Query tab editor places the three query types above the query text box,
while the Profiles version puts the same control below the query text box.
* The Query tab edit places the query types vertically, the provides version
horizontally.
* Similarly the Query tab editor puts the Ctrl+Enter hint above the text box,
Profiles puts it below.
A first request is to unify the two editors. In particular, move the code to a
common template file included in both places. PR #2052 used copy/paste to
narrow the gap. A better solution is to place the query editor in a shared
included template file.
Second, the Profiles editor is a bit redundant.
* Displays a "Cancel Query" button even if the query is completed. Hide this
button for completed queries. (Since there is a race condition, hide it for
queries completed at the time the page was created.)
* No need to ask the user for the query type. The profile includes the type
and the type should be a fixed field in Profiles.
* Similarly, the limit and (in Drill 1.18) the Default Schema should also be
recorded in the query plan and fixed. (The profile must change to include this
value.)
Since system/session options can affect a query, and are part of the query
plan, show those in the query as well so it can be rerun in the same
environment in which it originally ran.
Finally, since no one knows how to create a logical or physical plan, omit the
query type control altogether.
> Revise query editor in profile page of web UI
> ---------------------------------------------
>
> Key: DRILL-7697
> URL: https://issues.apache.org/jira/browse/DRILL-7697
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Priority: Major
>
> Drill has two separate query editors:
> * The one displayed from the Query tab
> * The one displayed from the Edit Query tab within Profiles
> The two editors do basically the same thing, but have evolved as copies that
> have diverged.
> * The Query tab editor places the three query types above the query text
> box, while the Profiles version puts the same control below the query text
> box.
> * The Query tab edit places the query types vertically, the provides version
> horizontally.
> * Similarly the Query tab editor puts the Ctrl+Enter hint above the text
> box, Profiles puts it below.
> * The Query tab provides a drop-down of available schemas, but the Profile
> tab query editor does not.
> A first request is to unify the two editors. In particular, move the code to
> a common template file included in both places. PR #2052 used copy/paste to
> narrow the gap. A better solution is to place the query editor in a shared
> included template file.
> Second, the Profiles editor is a bit redundant.
> * Displays a "Cancel Query" button even if the query is completed. Hide this
> button for completed queries. (Since there is a race condition, hide it for
> queries completed at the time the page was created.)
> * No need to ask the user for the query type. The profile includes the type
> and the type should be a fixed field in Profiles.
> * Similarly, the limit and (in Drill 1.18) the Default Schema should also be
> recorded in the query plan and fixed. (The profile must change to include
> this value.)
> Since system/session options can affect a query, and are part of the query
> plan, show those in the query as well so it can be rerun in the same
> environment in which it originally ran.
> Finally, since no one knows how to create a logical or physical plan, omit
> the query type control altogether.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
