[
https://issues.apache.org/jira/browse/DRILL-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086809#comment-17086809
]
ASF GitHub Bot commented on DRILL-7706:
---------------------------------------
paul-rogers commented on pull request #2060: DRILL-7706: Implement Drill RDBMS
Metastore for Tables component
URL: https://github.com/apache/drill/pull/2060#discussion_r410831759
##########
File path:
metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/components/tables/RdbmsTables.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.metastore.rdbms.components.tables;
+
+import org.apache.drill.metastore.components.tables.TableMetadataUnit;
+import org.apache.drill.metastore.components.tables.Tables;
+import
org.apache.drill.metastore.components.tables.TablesMetadataTypeValidator;
+import org.apache.drill.metastore.operate.Metadata;
+import org.apache.drill.metastore.operate.Modify;
+import org.apache.drill.metastore.operate.Read;
+import org.apache.drill.metastore.rdbms.QueryExecutorProvider;
+import org.apache.drill.metastore.rdbms.RdbmsMetastoreContext;
+import org.apache.drill.metastore.rdbms.operate.RdbmsMetadata;
+import org.apache.drill.metastore.rdbms.operate.RdbmsModify;
+import org.apache.drill.metastore.rdbms.operate.RdbmsRead;
+import org.apache.drill.metastore.rdbms.transform.Transformer;
+
+/**
+ * Metastore Tables component which stores tables metadata in the
corresponding RDBMS tables:
+ * TABLES, SEGMENTS, FILES, ROW_GROUPS, PARTITIONS.
+ * Provides methods to read and modify tables metadata.
+ */
+public class RdbmsTables implements Tables,
RdbmsMetastoreContext<TableMetadataUnit> {
Review comment:
The term "tables" in a query engine is excessively overloaded. Do we mean
system tables, the physical table on disk, a Calcite representation of a table,
the metadata description of a table, ...? Perhaps rename the classes
`TableMetadata` or `TableDescription` (you pick a name) and
`RdbmsTableWhatever`. Else, my first thought was that this is the class that
will manage the tables (there is that term again) we created in the RDBMS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drill RDBMS Metastore
> ---------------------
>
> Key: DRILL-7706
> URL: https://issues.apache.org/jira/browse/DRILL-7706
> Project: Apache Drill
> Issue Type: New Feature
> Affects Versions: 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Priority: Major
> Fix For: 1.18.0
>
>
> Currently Drill has only one Metastore implementation based on Iceberg
> tables. Iceberg tables are file based storage that supports concurrent writes
> / reads but required to be placed on distributed file system.
> This Jira aims to implement Drill RDBMS Metastore which will store Drill
> Metastore metadata in the database of the user's choice. Currently,
> PostgreSQL and MySQL databases are supported, others might work as well but
> no testing was done. Also out of box for demonstration / testing purposes
> Drill will setup SQLite file based embedded database but this is only
> applicable for Drill in embedded mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
