[
https://issues.apache.org/jira/browse/DRILL-7727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097663#comment-17097663
]
ASF GitHub Bot commented on DRILL-7727:
---------------------------------------
vvysotskyi commented on a change in pull request #2071:
URL: https://github.com/apache/drill/pull/2071#discussion_r418724733
##########
File path: contrib/native/client/CMakeLists.txt
##########
@@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW)
cmake_policy(SET CMP0048 NEW)
enable_testing()
+#
+# required version for dependencies
+#
+set (BOOST_MINIMUM_VERSION 1.54.0)
+set (PROTOBUF_MINIMUM_VERSION 3.6.1)
Review comment:
It may cause issues for other places since protobuf files were
regenerated using 3.11 version. Looks like updating `readme.win.txt`
instruction was missed and should be fixed to be up-to-date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Address Protobuf C++ warnings
> -----------------------------
>
> Key: DRILL-7727
> URL: https://issues.apache.org/jira/browse/DRILL-7727
> Project: Apache Drill
> Issue Type: Test
> Components: Client - C++
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
> Priority: Minor
>
> Compiling C++ client with recent versions of protobuf (3.4.0 or higher)
> produces compilation warnings:
> {noformat}
> .../drill/contrib/native/client/src/clientlib/rpcMessage.cpp:208:32: warning:
> 'ByteSize' is deprecated: Please use ByteSizeLong() instead
> [-Wdeprecated-declarations]
> int header_length = header.ByteSize();
> ^
> /usr/local/include/google/protobuf/message_lite.h:401:3: note: 'ByteSize' has
> been explicitly marked deprecated here
> PROTOBUF_DEPRECATED_MSG("Please use ByteSizeLong() instead")
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
