[
https://issues.apache.org/jira/browse/DRILL-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115472#comment-17115472
]
ASF GitHub Bot commented on DRILL-7723:
---------------------------------------
vvysotskyi commented on a change in pull request #2069:
URL: https://github.com/apache/drill/pull/2069#discussion_r429674200
##########
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -75,7 +83,9 @@
private Row currentRow;
- private Workbook workbook;
+ private StreamingWorkbook swb;
Review comment:
This class uses only methods from the `Workbook` interface, so I don't
see any reason for narrowing down the type to `StreamingWorkbook` here and
adding explicit casts for this type.
##########
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -75,7 +83,9 @@
private Row currentRow;
- private Workbook workbook;
+ private StreamingWorkbook swb;
+
+ private CoreProperties fileMetadata;
Review comment:
It is called in a single method only. May be declared a local variable
in this method instead of adding the class field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Excel Metadata as Implicit Fields
> -------------------------------------
>
> Key: DRILL-7723
> URL: https://issues.apache.org/jira/browse/DRILL-7723
> Project: Apache Drill
> Issue Type: Improvement
> Components: Metadata, Storage - Text & CSV
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.18.0
>
>
> Excel files contain a significant number of metadata fields in them. This PR
> adds the ability to access these fields via implicit columns. The columns are:
> _category
> _content_status
> _content_type;
> _creator
> _description
> _identifier
> _keywords
> _last_modified_by_user
> _revision
> _subject
> _title
> _created
> _last_printed
> _modified
> These fields are not projected in star queries so there is no effect on
> existing queries.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
