[
https://issues.apache.org/jira/browse/DRILL-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139373#comment-17139373
]
ASF GitHub Bot commented on DRILL-7750:
---------------------------------------
sanel commented on a change in pull request #2088:
URL: https://github.com/apache/drill/pull/2088#discussion_r442177833
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigServer.java
##########
@@ -226,11 +230,26 @@ private String getHadoopConfigParam(String name) {
return value;
}
- private String resolveHadoopPropertyName(String nameTemplate, Mode mode) {
- return MessageFormat.format(nameTemplate, mode.toString().toLowerCase());
- }
+ private String getPasswordConfigParam(String name, String hadoopName) {
Review comment:
Looks good :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drill fails to read KeyStore password from Credential provider
> --------------------------------------------------------------
>
> Key: DRILL-7750
> URL: https://issues.apache.org/jira/browse/DRILL-7750
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.18
>
>
> When core-site.xml has keystore or truststore specific properties along with
> Hadoop's CredentialProvider path, e.g.:
> {code}
> <?xml version="1.0"?>
> <?xml-stylesheet type="text/xsl" href="configuration.xsl"?>
> <configuration>
> ...
> <property>
> <name>ssl.server.truststore.location</name>
> <value>/etc/conf/ssl_truststore</value>
> </property>
> <property>
> <name>ssl.server.truststore.type</name>
> <value>jks</value>
> </property>
> <property>
> <name>ssl.server.truststore.reload.interval</name>
> <value>10000</value>
> </property>
> <property>
> <name>ssl.server.keystore.location</name>
> <value>/etc/conf/ssl_keystore</value>
> </property>
> <property>
> <name>ssl.server.keystore.type</name>
> <value>jks</value>
> </property>
> <property>
> <name>hadoop.security.credential.provider.path</name>
> <value>jceks://file/etc/conf/ssl_server.jceks</property>
> </configuration>
> {code}
> Drill fails to start.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
