[
https://issues.apache.org/jira/browse/DRILL-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181376#comment-17181376
]
ASF GitHub Bot commented on DRILL-7780:
---------------------------------------
cgivre merged pull request #2097:
URL: https://github.com/apache/drill/pull/2097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Potentially Erroneous String Comparison by reference
> ----------------------------------------------------
>
> Key: DRILL-7780
> URL: https://issues.apache.org/jira/browse/DRILL-7780
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Nes Cohen
> Priority: Minor
> Labels: easyfix, pull-request-available
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Comparing strings in java by reference, even the empty string, can be
> problematic because two "equal" strings may be different objects with
> different references.
> This occurs notably in two locations:
> [https://github.com/apache/drill/blob/0726b83d9347cbb8bd1bc64a8d10c12c1125549a/exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java#L142]
> [https://github.com/apache/drill/blob/0726b83d9347cbb8bd1bc64a8d10c12c1125549a/common/src/main/java/org/apache/drill/common/KerberosUtil.java#L50|https://github.com/nescohen/drill/blob/0726b83d9347cbb8bd1bc64a8d10c12c1125549a/common/src/main/java/org/apache/drill/common/KerberosUtil.java#L50]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
