[ https://issues.apache.org/jira/browse/DRILL-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216270#comment-17216270 ]
ASF GitHub Bot commented on DRILL-7763: --------------------------------------- cgivre commented on pull request #2092: URL: https://github.com/apache/drill/pull/2092#issuecomment-711191164 @vvysotskyi I fixed the import orders. Regarding the extra constructor, I modified the `applyLimit` method a bit which I think does what you're asking. Instead of modifying in place, it returns a new GroupScan with the limit value set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Limit Pushdown to File Based Storage Plugins > ------------------------------------------------ > > Key: DRILL-7763 > URL: https://issues.apache.org/jira/browse/DRILL-7763 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.17.0 > Reporter: Charles Givre > Assignee: Charles Givre > Priority: Major > Fix For: 1.19.0 > > > As currently implemented, when querying a file, Drill will read the entire > file even if a limit is specified in the query. This PR does a few things: > # Refactors the EasyGroupScan, EasySubScan, and EasyFormatConfig to allow > the option of pushing down limits. > # Applies this to all the EVF based format plugins which are: LogRegex, > PCAP, SPSS, Esri, Excel and Text (CSV). > Due to JSON's fluid schema, it would be unwise to adopt the limit pushdown as > it could result in very inconsistent schemata. -- This message was sent by Atlassian Jira (v8.3.4#803005)