[
https://issues.apache.org/jira/browse/DRILL-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312882#comment-17312882
]
ASF GitHub Bot commented on DRILL-7828:
---------------------------------------
paul-rogers commented on a change in pull request #2192:
URL: https://github.com/apache/drill/pull/2192#discussion_r605396832
##########
File path:
contrib/format-pcapng/src/main/java/org/apache/drill/exec/store/plugin/PcapFormatConfig.java
##########
@@ -29,18 +29,23 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonTypeName;
-@JsonTypeName(PcapngFormatConfig.NAME)
+@JsonTypeName(PcapFormatConfig.NAME)
@JsonInclude(JsonInclude.Include.NON_DEFAULT)
-public class PcapngFormatConfig implements FormatPluginConfig {
+public class PcapFormatConfig implements FormatPluginConfig {
+ private static final List<String> DEFAULT_EXTNS = ImmutableList.of("pcap",
"pcapng");
- public static final String NAME = "pcapng";
+ public static final String NAME = "pcap";
private final List<String> extensions;
private final boolean stat;
+ private final boolean sessionizeTCPStreams;
@JsonCreator
- public PcapngFormatConfig(@JsonProperty("extensions") List<String>
extensions, @JsonProperty("stat") boolean stat) {
- this.extensions = extensions == null ?
ImmutableList.of(PcapngFormatConfig.NAME) : ImmutableList.copyOf(extensions);
+ public PcapFormatConfig(@JsonProperty("extensions") List<String> extensions,
+ @JsonProperty("stat") boolean stat,
+ @JsonProperty("sessionizeTCPStreams") Boolean
sessionizeTCPStreams) {
Review comment:
Thanks for the explanation. If the property already existed, then we
must leave it to preserve backward compatibility. I guess we should have caught
the issue when the property was originally added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor Pcap and Pcapng format plugin
> --------------------------------------
>
> Key: DRILL-7828
> URL: https://issues.apache.org/jira/browse/DRILL-7828
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Cong Luo
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.19.0
>
>
> We can check the file's magic number, If that magic number indicates PCAP
> then use the existing reader, If the magic number indicates PCAPNG, use the
> refactored NG reader.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
