[
https://issues.apache.org/jira/browse/DRILL-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314663#comment-17314663
]
ASF GitHub Bot commented on DRILL-7814:
---------------------------------------
cgivre commented on pull request #2120:
URL: https://github.com/apache/drill/pull/2120#issuecomment-813171609
> @cgivre, there are some additional follow-up changes that should be made.
In `matches()` method and in the first line of `onMatch()` please replace
`DrillScanRel` with `DrillScanRelBase`. When creating `newScanPrel`, it should
be either `ScanPrel` or `DrillScanRel`, depending on the type of `scan`.
@vvysotskyi
Thanks for the response. I made a few changes but am stuck again. It would
seem that I need to check the query phase, but I'm not quite sure how to do
that. This is the error I'm getting now.
```
org.apache.drill.exec.rpc.RpcException:
org.apache.drill.common.exceptions.UserRemoteException: SYSTEM ERROR:
AssertionError: Relational expression ScanPrel#133 has calling-convention
LOGICAL but does not implement the required interface 'interface
org.apache.drill.exec.planner.logical.DrillRel' of that convention
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Limit Pushdown to MongoDB Storage Plugin
> --------------------------------------------
>
> Key: DRILL-7814
> URL: https://issues.apache.org/jira/browse/DRILL-7814
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - MongoDB
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.19.0
>
>
> Drill's MongoDB plugin does not push limits down to Mongo. This PR adds this
> capability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
