[ 
https://issues.apache.org/jira/browse/DRILL-7904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331519#comment-17331519
 ] 

ASF GitHub Bot commented on DRILL-7904:
---------------------------------------

vdiravka commented on a change in pull request #2202:
URL: https://github.com/apache/drill/pull/2202#discussion_r619815679



##########
File path: distribution/src/assemble/component.xml
##########
@@ -90,9 +90,6 @@
       <outputDirectory>jars</outputDirectory>
       <unpack>false</unpack>
       <useProjectArtifact>false</useProjectArtifact>
-      <includes>
-        <include>org.apache.drill:drill-shaded-guava:jar</include>
-      </includes>
     </dependencySet>
 
     <dependencySet>

Review comment:
       right, thanks!

##########
File path: docs/dev/ArtidfactsPublishing.md
##########
@@ -1,22 +1,8 @@
-# How to upgrade Guava in Drill

Review comment:
       I thought to it too. But this info can be useful for any other library 
shade, can't it be?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update to 30-jre Guava version
> ------------------------------
>
>                 Key: DRILL-7904
>                 URL: https://issues.apache.org/jira/browse/DRILL-7904
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.18.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.18.0
>
>
> * Update guava version to the newest one 
> ([30.1.1-jre|https://mvnrepository.com/artifact/com.google.guava/guava/30.1.1-jre])
>  * Drop <shaded.guava.version> at all



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to