[
https://issues.apache.org/jira/browse/DRILL-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338056#comment-17338056
]
ASF GitHub Bot commented on DRILL-7912:
---------------------------------------
cgivre commented on a change in pull request #2211:
URL: https://github.com/apache/drill/pull/2211#discussion_r624710583
##########
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -116,6 +117,23 @@ public String getFieldName() {
}
}
+ private enum IMPLICIT_LIST_COLUMN {
+ /**
+ * A list of the available sheets in the file.
+ */
+ SHEETS("_sheets");
+
+ private final String fieldName;
+
+ IMPLICIT_LIST_COLUMN(String fieldName) {
+ this.fieldName = fieldName;
+ }
+
+ public String getFieldName() {
Review comment:
I don't believe that will work in this case. The line `this.fieldName =
fieldName` assigns the variable. If you call `getFieldName()` when that is not
assigned, you will get some error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Sheet Names to Excel Reader
> -------------------------------
>
> Key: DRILL-7912
> URL: https://issues.apache.org/jira/browse/DRILL-7912
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.18.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.19.0
>
>
> Currently, there is no way to determine what sheets are available in an Excel
> file. This PR adds a metadata field called `_sheets` which a user can query
> to determine available sheets in a given file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
