[
https://issues.apache.org/jira/browse/DRILL-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355692#comment-17355692
]
ASF GitHub Bot commented on DRILL-7938:
---------------------------------------
luocooong commented on a change in pull request #2241:
URL: https://github.com/apache/drill/pull/2241#discussion_r643936655
##########
File path:
contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithH2IT.java
##########
@@ -53,6 +54,10 @@
@BeforeClass
public static void init() throws Exception {
startCluster(ClusterFixture.builder(dirTestWatcher));
+ // Force timezone to UTC for these tests.
Review comment:
I recommend that :
```java
private static TimeZone defaultTimeZone;
@BeforeClass
public static void setUp() {
defaultTimeZone = TimeZone.getDefault();
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
}
@AfterClass
public static void cleanUp() {
TimeZone.setDefault(defaultTimeZone);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Convert JDBC Storage Plugin to EVF
> ----------------------------------
>
> Key: DRILL-7938
> URL: https://issues.apache.org/jira/browse/DRILL-7938
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - JDBC
> Affects Versions: 1.18.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Minor
> Fix For: 1.19.0
>
>
> The JDBC plugin currently uses the older vector objects. As part of a
> massive code cleanup, this PR updates the plugin to use the newer EVF
> framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
