[
https://issues.apache.org/jira/browse/DRILL-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356559#comment-17356559
]
ASF GitHub Bot commented on DRILL-7941:
---------------------------------------
martin-g commented on a change in pull request #2244:
URL: https://github.com/apache/drill/pull/2244#discussion_r644947522
##########
File path: common/pom.xml
##########
@@ -37,11 +37,21 @@
<artifactId>drill-protocol</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>${junit.version}</version>
+ </dependency>
<dependency>
<!-- add as provided scope so that we can compile TestTools. Should
only be ever used in a test scenario where someone else is bringing JUnit in.
-->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>${junit.version}</version>
+ <scope>provided</scope>
Review comment:
@vvysotskyi RepeatTestRule is currently at
common/src/main/java/org/apache/drill/common/util/RepeatTestRule.java
But it is used by:
1)
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java
2) common/src/test/java/org/apache/drill/test/TestTools.java
So, to do what you suggest I have to copy it in two modules - java-exec and
common.
Or to move it in common/src/test/... and then in java-exec/pom.xml to add a
dependency to common-tests.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update JUnit from 4.13.2 to 5.7.2
> ---------------------------------
>
> Key: DRILL-7941
> URL: https://issues.apache.org/jira/browse/DRILL-7941
> Project: Apache Drill
> Issue Type: Task
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
>
> Currently Drill uses JUnit 4.13.2 as a unit test framework.
> It could be easily upgraded to JUnit 5.x by using junit-vintage-engine that
> provides same APIs as JUnit 4.x.
> The benefit is that this way any new tests could be written with JUnit 5.x
> APIs and all old test classes could be gradually migrated over time if
> desired.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
