[
https://issues.apache.org/jira/browse/DRILL-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356774#comment-17356774
]
ASF GitHub Bot commented on DRILL-7945:
---------------------------------------
laurentgo opened a new pull request #2247:
URL: https://github.com/apache/drill/pull/2247
# [DRILL-7945](https://issues.apache.org/jira/browse/DRILL-7945): Stop
patching newly added Guava methods
## Description
In order to support Apache Iceberg, GuavaPatcher adds several methods to
com.google.common.base.Preconditions required by Apache Iceberg runtime
but not available in Guava 18.
When Guava version was updated to 30.1.1, Guava Patcher tries to update
existing methods with some code referencing package protected methods
which do no exist anymore. Patching fails but as the methods do now
exists, there's no compatibility issue. That said, GuavaPatcher emits
some logging which might confuse end user.
Remove the unnecessary patching of the Preconditions class and also add
some unit test designed to fail if patching fails for any reason.
## Documentation
N/A
## Testing
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unable to patch Guava classes
> -----------------------------
>
> Key: DRILL-7945
> URL: https://issues.apache.org/jira/browse/DRILL-7945
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.19.0
> Reporter: Vova Vysotskyi
> Assignee: Vitalii Diravka
> Priority: Blocker
> Fix For: 1.19.0
>
>
> When starting Drill in embedded mode, logs have the following line:
> {noformat}
> 2021-06-03 21:59:07,711 [main] WARN o.a.drill.common.util.GuavaPatcher -
> Unable to patch Guava classes: [source error]
> format(java.lang.String,java.lang.Object[]) not found in
> com.google.common.base.Preconditions
> {noformat}
> Most likely it is a regression after DRILL-7904.
> The importance of this issue is that all 3rd party libraries that initially
> relied on patched methods from {{Preconditions}} will stop working because of
> method not found errors during the runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
