[
https://issues.apache.org/jira/browse/DRILL-7943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357172#comment-17357172
]
ASF GitHub Bot commented on DRILL-7943:
---------------------------------------
martin-g commented on pull request #2246:
URL: https://github.com/apache/drill/pull/2246#issuecomment-853636660
> Just curious but is there a reason why we don't just use `junit` and
remove this dependency altogether?
JUnit provides just `Assert.assertThat(String reason, T actual, Matcher<?
super T> matcher)`, Hamcrest provides the actual matcher implementations.
JUnit's `assertThat()` is linked to Hamcrest 1.3 Matcher. This is the reason
to replace it with `org.hamcrest.MatcherAssert.assertThat()` in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Hamcrest to 2.2
> ----------------------
>
> Key: DRILL-7943
> URL: https://issues.apache.org/jira/browse/DRILL-7943
> Project: Apache Drill
> Issue Type: Task
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
>
> Update Hamcrest testing library from 1.3 to 2.2.
> Update all usages of org.junit.Assert.assertThat() to
> org.hamcrest.MatcherAssert.assertThat()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
