[ 
https://issues.apache.org/jira/browse/DRILL-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375654#comment-17375654
 ] 

ASF GitHub Bot commented on DRILL-7968:
---------------------------------------

luocooong commented on a change in pull request #2267:
URL: https://github.com/apache/drill/pull/2267#discussion_r664458580



##########
File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestMetastoreCommands.java
##########
@@ -3531,6 +3531,40 @@ public void testAnalyzeWithNonWritableWorkspace() throws 
Exception {
     run("analyze table dfs.%s.%s refresh metadata", workspaceName, tableName);
   }
 
+  @Test
+  public void testAnalyzeAllTypes7kRows() throws Exception {
+    // See DRILL-7968.  More rows are produced here to test an ANALYZE code 
path

Review comment:
       May be shortened to : 
   ```java
   @Test // DRILL-7968
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ANALYZE TABLE ... REFRESH METADATA fails with FLOAT4 column 
> ------------------------------------------------------------
>
>                 Key: DRILL-7968
>                 URL: https://issues.apache.org/jira/browse/DRILL-7968
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Metadata
>    Affects Versions: 1.19.0
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Minor
>             Fix For: 1.20.0
>
>
> For tables with fewer than ~200 rows and a FLOAT4 column there is no bug: the 
> ANALYZE command succeeds and, indeed, this case is exercised by tests in 
> TestMetastoreCommands.java and alltypes_\{required,optional}.parquet which 
> both contain a FLOAT4 column.
> But for tables with more than ~200 rows and a FLOAT4 column the ANALYZE 
> command fails with
> ```
> SQL Error: EXECUTION_ERROR ERROR: PojoRecordReader doesn't yet support 
> conversions from the type [class java.lang.Float].
> Failed to setup reader: DynamicPojoRecordReader
> ```
> E.g. you can reproduce the above with
> ```
> create table dfs.tmp.test_analyze as 
>  select cast(1 as float) from cp.`employee.json`;
> analyze table dfs.tmp.test_analyze refresh metadata;
>  ```
> I believe that the bug is easily fixed by adding support for Java.lang.Float 
> to PojoWriters.java.  I do not know why it requires more than ~200 rows for 
> the code path through PojoRecordReader to come into play, and for this bug to 
> manifest.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to