[
https://issues.apache.org/jira/browse/DRILL-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396946#comment-17396946
]
ASF GitHub Bot commented on DRILL-7973:
---------------------------------------
cgivre commented on a change in pull request #2293:
URL: https://github.com/apache/drill/pull/2293#discussion_r686399026
##########
File path:
contrib/storage-http/src/test/java/org/apache/drill/exec/store/http/TestHttpPlugin.java
##########
@@ -585,7 +585,7 @@ public void testSlowResponse() throws Exception {
server.enqueue(
new MockResponse().setResponseCode(200)
.setBody(TEST_JSON_RESPONSE)
- .throttleBody(64, 4, TimeUnit.SECONDS)
Review comment:
@vdiravka
Thanks for the PR. For this test, we could also set the timeout for the
plugin config to be say 1 seconds and set the throttle to be 2. Just a
suggestion. The goal with this test was just to make sure the plugin does in
fact time out and throw the appropriate exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix GitHub CI intermittent failures
> -----------------------------------
>
> Key: DRILL-7973
> URL: https://issues.apache.org/jira/browse/DRILL-7973
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Tools, Build & Test
> Affects Versions: 1.19.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.20.0
>
>
> *The memory issue:*
> I got locally:
> {code:java}
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.264
> s - in org.apache.drill.exec.work.metadata.TestServerMetaProvider
> [ERROR] Tests run: 19, Failures: 0, Errors: 2, Skipped: 0, Time elapsed:
> 7.713 s <<< FAILURE! - in org.apache.drill.exec.record.vector.TestValueVector
> [ERROR]
> org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation
> Time elapsed: 0.084 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected<org.apache.drill.exec.exception.OversizedAllocationException> but
> was<org.apache.drill.exec.exception.OutOfMemoryException>
> at
> org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)
> Caused by: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate
> 2147483644 byte(s) of direct memory (used: 872415232, max: 2621440000)
> at
> org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)[ERROR]
>
> org.apache.drill.exec.record.vector.TestValueVector.testVariableVectorReallocation
> Time elapsed: 0.013 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected<org.apache.drill.exec.exception.OversizedAllocationException> but
> was<org.apache.drill.exec.exception.OutOfMemoryException>
> at
> org.apache.drill.exec.record.vector.TestValueVector.testVariableVectorReallocation(TestValueVector.java:165)
> Caused by: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate
> 2147483647 byte(s) of direct memory (used: 872415232, max: 2621440000)
> at
> org.apache.drill.exec.record.vector.TestValueVector.testVariableVectorReallocation(TestValueVector.java:165)
> {code}
> for the command:
> {code:java}
> drill$ mvn install -V -ntp -DdirectMemoryMb=2500 -DmemoryMb=2000{code}
> andÂ
> {code:java}
> [INFO] Running org.apache.drill.exec.work.metadata.TestServerMetaProvider
> [ERROR] Tests run: 19, Failures: 0, Errors: 2, Skipped: 0, Time elapsed:
> 6.358 s <<< FAILURE! - in org.apache.drill.exec.record.vector.TestValueVector
> [ERROR]
> org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation
> Time elapsed: 0.048 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected<org.apache.drill.exec.exception.OversizedAllocationException> but
> was<org.apache.drill.exec.exception.OutOfMemoryException>
> at
> org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)
> Caused by: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate
> 2147483644 byte(s) of direct memory (used: 989855744, max: 2936012800)
> at
> org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)[ERROR]
>
> org.apache.drill.exec.record.vector.TestValueVector.testVariableVectorReallocation
> Time elapsed: 0.008 s <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected<org.apache.drill.exec.exception.OversizedAllocationException> but
> was<org.apache.drill.exec.exception.OutOfMemoryException>
> at
> org.apache.drill.exec.record.vector.TestValueVector.testVariableVectorReallocation(TestValueVector.java:165)
> Caused by: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate
> 2147483647 byte(s) of direct memory (used: 989855744, max: 2936012800)
> at
> org.apache.drill.exec.record.vector.TestValueVector.testVariableVectorReallocation(TestValueVector.java:165)
> {code}
> for the command:
> {code:java}
> mvn install -V -ntp -DdirectMemoryMb=2800 -DmemoryMb=2000{code}
> There are also intermittent failures for several test cases, details in
> comments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
