[
https://issues.apache.org/jira/browse/DRILL-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416135#comment-17416135
]
ASF GitHub Bot commented on DRILL-7999:
---------------------------------------
vvysotskyi commented on a change in pull request #2317:
URL: https://github.com/apache/drill/pull/2317#discussion_r710157786
##########
File path: Dockerfile
##########
@@ -16,31 +16,43 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project
sources into the build image, builds
-# Drill and copies built binaries into the target image based on
openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_IMAGE
+# build arg which you should set when invoking docker build.
+# Example syntax: docker build --build-arg BASE_IMAGE="openjdk:8-jre"
-# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+ARG $BASE_IMAGE=openjdk:11-jre
Review comment:
Please use JDK 8 as a default one.
##########
File path: Dockerfile
##########
@@ -16,31 +16,43 @@
# limitations under the License.
#
-# This Dockerfile is used for automated builds in DockerHub. It adds project
sources into the build image, builds
-# Drill and copies built binaries into the target image based on
openjdk:8u232-jdk image.
+# This Dockerfile is used for automated builds in DockerHub. It adds
+# project sources into the build image, builds Drill and copies built
+# binaries into the target image based on the image name in BASE_IMAGE
+# build arg which you should set when invoking docker build.
+# Example syntax: docker build --build-arg BASE_IMAGE="openjdk:8-jre"
-# Uses intermediate image for building Drill to reduce target image size
-FROM maven:3.6.3-jdk-8 as build
+ARG $BASE_IMAGE=openjdk:11-jre
-# Copy project sources into the container
-COPY . /src
+# Uses intermediate image for building Drill to reduce target image size
+# Build using OpenJDK 8 to maintain compatibility with all OpenJDK >= 8
+FROM maven:3.8.2-openjdk-8 as build
Review comment:
It can be made configurable too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Base Docker image on maven:3.8.2-jdk-11 and openjdk-11
> ------------------------------------------------------
>
> Key: DRILL-7999
> URL: https://issues.apache.org/jira/browse/DRILL-7999
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.19.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 1.20.0
>
>
> Our Docker container builds on OpenJDK 8u232 released late in 2019, while the
> current LTS release of OpenJDK is 11. Update our Dockerfile to OpenJDK 11
> and address the following report from a user in a Github issue at the same
> time.
> {quote}It would be great if the Docker image could be improved;
> {quote} #
> {quote}Drill documentation referrs to $DRILL_HOME environment variable which
> is not set in the Docker Image. Additionally in the doucmenation says it can
> be found in {{/etc/drill/conf}} while in the Docker image Drill has been
> installed into {{/opt/drill/conf}}{quote}
> #
> {quote}Add information how to add (mount) custom configuration files into the
> Docker image or even better, just make sure there is a Docker section in
> Drill's documentation whereever appropriate{quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
