[
https://issues.apache.org/jira/browse/DRILL-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440583#comment-17440583
]
ASF GitHub Bot commented on DRILL-8039:
---------------------------------------
lgtm-com[bot] commented on pull request #2365:
URL: https://github.com/apache/drill/pull/2365#issuecomment-963351240
This pull request **fixes 35 alerts** when merging
260ebff1d3a98416fdbb99c14187827543ff6645 into
52838ef26e5e3e6b4461c2c656ffada0c64c9e88 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/drill/rev/pr-1b7d7e8bd69d2150467685ad4243833e1f87d7b6)
**fixed alerts:**
* 26 for Unused format argument
* 3 for Spurious Javadoc @param tags
* 3 for Missing format argument
* 1 for Useless comparison test
* 1 for Implicit conversion from array to string
* 1 for Comparison of identical values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> More LGTM Code Cleanup
> ----------------------
>
> Key: DRILL-8039
> URL: https://issues.apache.org/jira/browse/DRILL-8039
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.20.0
>
>
> This PR fixes a few groups of LGTM issues:
> * Hides false positive alerts for Array index out of bounds (10 alerts)
> * Comparison of identical values (1 alert)
> * Missing format arguments (4 alerts)
> * Unused format argument (27 alerts)
> * Broken or risky crypto algorithms (2 alerts)
> * Implicit conversion from array to String (1 alert)
> * Spurious Javadoc (2 files)
> None of these affect functionality. Most relate to code maintainability and
> error messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
