[ 
https://issues.apache.org/jira/browse/DRILL-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443234#comment-17443234
 ] 

ASF GitHub Bot commented on DRILL-8043:
---------------------------------------

cgivre opened a new pull request #2372:
URL: https://github.com/apache/drill/pull/2372


   # [DRILL-8043](https://issues.apache.org/jira/browse/DRILL-8043): Excel 
Reader Regression Fix
   
   ## Description
   DRILL-8033 (https://github.com/apache/drill/pull/2363) caused a regression 
with reading excel files.  See 
(https://github.com/pjfanning/excel-streaming-reader/issues/76)  This PR 
reverts back to the previous version of POI.
   
   The issue seems to be related to the change in logging in POI to log4j 2.x.  
I attempted to exclude the logger in POI as well as include 
`org.apache.logging.log4j:log4j-to-slf4j:2.14.1` in the Excel module.  Neither 
solved the issue.  For the time being I would propose we revert back to the 
original dependencies which work. 
   
   As a bit of an aside, I found it curious that the unit tests all 
successfully completed, but when you tried to query Excel normally, the queries 
all failed. It might be worth looking into why that is the case.
   
   ## Documentation
   No user facing changes.
   
   ## Testing
   Ran all unit tests and manually ran queries on Excel files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Excel Reader Regression Fix
> ---------------------------
>
>                 Key: DRILL-8043
>                 URL: https://issues.apache.org/jira/browse/DRILL-8043
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Other
>    Affects Versions: 1.19.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Blocker
>             Fix For: 1.20.0
>
>
> DRILL-8033 caused a regression with reading excel files.  See 
> ([https://github.com/pjfanning/excel-streaming-reader/issues/76)]  This PR 
> reverts back to the previous version of POI.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to