[
https://issues.apache.org/jira/browse/DRILL-8034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444283#comment-17444283
]
ASF GitHub Bot commented on DRILL-8034:
---------------------------------------
vvysotskyi commented on a change in pull request #2377:
URL: https://github.com/apache/drill/pull/2377#discussion_r749927866
##########
File path: distribution/src/main/resources/drill-config.sh
##########
@@ -307,10 +307,11 @@ export DRILLBIT_OPTS="$DRILLBIT_OPTS
-XX:ReservedCodeCacheSize=$DRILLBIT_CODE_CA
if [ $? -gt 0 ]; then
# Allow reflective access on Java 9+
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/java.lang=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS
--add-opens=java.base/java.util=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/sun.nio.ch=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/java.net=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/java.nio=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.security.jgss/sun.security.krb5=ALL-UNNAMED"
- export DRILLBIT_OPTS="$DRILLBIT_OPTS --illegal-access=permit"
Review comment:
Perhaps it was added to prevent extra warnings, but I've checked, and
jor JDK 17 there are no warnings when starting Drill.
##########
File path: pom.xml
##########
@@ -1015,6 +1017,11 @@
<artifactId>asm</artifactId>
<version>${asm.version}</version>
</dependency>
+ <dependency>
Review comment:
`maven-shade-plugin` fails to package jar when we are setting
`maven.compiler.source` and `maven.compiler.target` to 17 (we will have to set
it when will decide to use newer features).
##########
File path: distribution/src/main/resources/drill-config.sh
##########
@@ -307,10 +307,11 @@ export DRILLBIT_OPTS="$DRILLBIT_OPTS
-XX:ReservedCodeCacheSize=$DRILLBIT_CODE_CA
if [ $? -gt 0 ]; then
# Allow reflective access on Java 9+
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/java.lang=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS
--add-opens=java.base/java.util=ALL-UNNAMED"
export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/sun.nio.ch=ALL-UNNAMED"
+ export DRILLBIT_OPTS="$DRILLBIT_OPTS --add-opens
java.base/java.net=ALL-UNNAMED"
Review comment:
Yes, there are more limitations that appear after JDK 14.
##########
File path: pom.xml
##########
@@ -3965,6 +3972,22 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>jdk15</id>
Review comment:
Thanks, renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Java17
> --------------
>
> Key: DRILL-8034
> URL: https://issues.apache.org/jira/browse/DRILL-8034
> Project: Apache Drill
> Issue Type: Wish
> Components: Execution - Codegen
> Affects Versions: 1.19.0
> Reporter: Vitalii Diravka
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: Future
>
>
> Drill officially supports Java14, and it can be updated to Java15 with a
> minimal changes. But latest LTS Java version is 17. Need to add support of
> building Drill with JVM17 and running on that JVM.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
