[ 
https://issues.apache.org/jira/browse/DRILL-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454750#comment-17454750
 ] 

ASF GitHub Bot commented on DRILL-8072:
---------------------------------------

vvysotskyi commented on a change in pull request #2397:
URL: https://github.com/apache/drill/pull/2397#discussion_r764191641



##########
File path: 
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
##########
@@ -37,6 +37,7 @@
 import org.apache.drill.exec.store.http.HttpStoragePluginConfig;
 import org.apache.drill.exec.store.http.HttpSubScan;
 import org.apache.drill.exec.store.security.UsernamePasswordCredentials;
+import org.apache.parquet.Strings;

Review comment:
       Please use `StringUtils` from commons-lang3 instead of using this method 
from the parquet library...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Fix NPE in HTTP Post Requests
> -----------------------------
>
>                 Key: DRILL-8072
>                 URL: https://issues.apache.org/jira/browse/DRILL-8072
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Other
>    Affects Versions: 1.19.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.20.0
>
>
> There was a minor bug in the HTTP Storage Plugin with POST requests.  If the 
> `postBody` configuration parameter is null, the plugin throws an NPE. 
> This PR adds a null check which prevents the NPE.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to