[
https://issues.apache.org/jira/browse/DRILL-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461858#comment-17461858
]
ASF GitHub Bot commented on DRILL-8071:
---------------------------------------
pjfanning opened a new pull request #2409:
URL: https://github.com/apache/drill/pull/2409
# [DRILL-8071](https://issues.apache.org/jira/browse/DRILL-8071): upgrade
log4j to 2.17.0
## Description
Drill's format-excel has only gained log4j dependencies recently (and this
is not in any Drill release yet).
Log4J have released 2.17.0 with another CVE fix. These CVEs don't affect
Drill because it does not yet use log4j-core but for optics, it is better to
update all log4j jars.
https://logging.apache.org/log4j/2.x/security.html
## Documentation
No changes
## Testing
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> format-excel data parsing should use POI code
> ---------------------------------------------
>
> Key: DRILL-8071
> URL: https://issues.apache.org/jira/browse/DRILL-8071
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Data Types
> Affects Versions: 1.19.0
> Reporter: PJ Fanning
> Priority: Major
>
> There is also custom code for handling the conversion of the raw numbers
> representing dates/timestamps but this also seems like a bad idea. The Cell
> class has getLocalDateTimeCellValue and this has the right logic for
> converting 1904 and 1900 based dates - yes, Excel uses 2 different formats.
> Code that processes excel files is a real pain to get right because the
> Microsoft storage format is really bad.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
