[
https://issues.apache.org/jira/browse/DRILL-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463925#comment-17463925
]
ASF GitHub Bot commented on DRILL-8028:
---------------------------------------
cgivre commented on pull request #2359:
URL: https://github.com/apache/drill/pull/2359#issuecomment-999686126
@paul-rogers
This PR is now ready for review. I did some research into the `headless`
option and why specifically I was not getting this issue when I ran unit tests,
and only when I ran manual queries. So, the issue was caused when PDFBox opens
a document, it calls some AWT libraries that it needs for deciphering PDF
files. (Also probably for writing PDF files) In any event, this is what was
causing the window to open.
When Drill runs the unit tests, we actually have the `headless` option
specified as a Java option. So, I moved this setting to `drill-config.sh` and
included a comment about why it is there. If someone wants to remove it for
some reason, they can and they can disable the PDF functionality simply by not
including it in the configs for the storage plugin. This seems like the right
place for this to live.
I believe that I've addressed all your other comments as well. Thank you as
always for the thorough review! It's ready for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add PDF Format Plugin
> ---------------------
>
> Key: DRILL-8028
> URL: https://issues.apache.org/jira/browse/DRILL-8028
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.20.0
>
>
> See PR for documentation. This PR adds the ability to read tables contained
> in PDF files.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
