[
https://issues.apache.org/jira/browse/DRILL-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468210#comment-17468210
]
ASF GitHub Bot commented on DRILL-8090:
---------------------------------------
cgivre commented on pull request #2420:
URL: https://github.com/apache/drill/pull/2420#issuecomment-1004366424
> @cgivre, yes, it is a good idea. I've noticed that we have a lot of common
test cases for different databases. It would be good to refactor those tests to
avoid copying them.
How did you have in mind? When I wrote the JDBC reader, I added tests for
Postgres and one other. I duplicated all the writer tests for a bunch of
databases. Is there a more efficient way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> LIMIT clause is pushed down to an invalid OFFSET-FETCH clause for MS SQL
> Server
> --------------------------------------------------------------------------------
>
> Key: DRILL-8090
> URL: https://issues.apache.org/jira/browse/DRILL-8090
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.19.0
> Reporter: James Turton
> Assignee: Vova Vysotskyi
> Priority: Major
>
> In MS SQL Server, ORDER BY is mandatory for using OFFSET and FETCH clauses.
> Drill (or Calcite) does not include an ORDER BY clause in the SQL it
> generates for a LIMIT clause.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
