[
https://issues.apache.org/jira/browse/DRILL-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470003#comment-17470003
]
ASF GitHub Bot commented on DRILL-8092:
---------------------------------------
cgivre commented on a change in pull request #2414:
URL: https://github.com/apache/drill/pull/2414#discussion_r779657432
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpBatchReader.java
##########
@@ -216,13 +246,15 @@ protected HttpProxyConfig proxySettings(Config
drillConfig, HttpUrl url) {
@Override
public boolean next() {
- recordCount++;
+ boolean result = jsonLoader.readBatch();
- // Stop after the limit has been reached
- if (maxRecords >= 1 && recordCount > maxRecords) {
- return false;
+ // Allows limitless pagination.
+ if (paginator != null &&
+ maxRecords < 0 && (resultSetLoader.totalRowCount()) <
paginator.getMaxPageSize()) {
+ logger.debug("Ending pagination: Pages too small");
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Auto Pagination to HTTP Storage Plugin
> ------------------------------------------
>
> Key: DRILL-8092
> URL: https://issues.apache.org/jira/browse/DRILL-8092
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.20.0
>
>
> See github
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
