[ 
https://issues.apache.org/jira/browse/DRILL-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471079#comment-17471079
 ] 

ASF GitHub Bot commented on DRILL-8060:
---------------------------------------

luocooong commented on pull request #2389:
URL: https://github.com/apache/drill/pull/2389#issuecomment-1007949898


   @vvysotskyi Thanks for the information. The previous decision to add Input 
Conversion was due to a new ERROR with the addition of unit tests, refer to :
   ```
   Caused by: java.lang.AssertionError: rowtype mismatches expressions
     at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
     at org.apache.calcite.rex.RexUtil.compatibleTypes(RexUtil.java:967)
     at org.apache.calcite.rel.core.Project.isValid(Project.java:185)
     at org.apache.calcite.rel.core.Project.<init>(Project.java:83)
     at 
org.apache.drill.exec.planner.common.DrillProjectRelBase.<init>(DrillProjectRelBase.java:67)
     at 
org.apache.drill.exec.store.plan.rel.PluginProjectRel.<init>(PluginProjectRel.java:43)
     at 
org.apache.drill.exec.store.plan.rule.PluginProjectRule.createPluginProject(PluginProjectRule.java:93)
     at 
org.apache.drill.exec.store.plan.rule.PluginProjectRule.convert(PluginProjectRule.java:68)
     at 
org.apache.calcite.rel.convert.ConverterRule.onMatch(ConverterRule.java:144)
     at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:208)
     at 
org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:633)
     at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:327)
     at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:405)
     at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:351)
     at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:245)
     at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:308)
     at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:173)
     at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:283)
     at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:163)
     at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:128)
     at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:93)
     at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:593)
     at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:274)
     ... 1 more
   ```
   If there is a way to not rely on Input Conversion, that might be better, 
please let me know, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Avoid the NPE in the Filter of Iceberg Implementor
> --------------------------------------------------
>
>                 Key: DRILL-8060
>                 URL: https://issues.apache.org/jira/browse/DRILL-8060
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Cong Luo
>            Assignee: Cong Luo
>            Priority: Blocker
>             Fix For: 1.20.0
>
>
> Query the phoenix data using the filter got the NPE (stack error at the 
> Iceberg format module), because the _#canImplement(Filter filter)_ might 
> accept a _*JDBCTableScan*_ (or an object that extend the _*TableScan*_ of 
> Calcite), then _#getDrillTable(TableScan)_ will get the null.
> {code:java}
> Caused by: java.lang.NullPointerException: null
>         at 
> org.apache.drill.exec.store.iceberg.plan.IcebergPluginImplementor.canImplement(IcebergPluginImplementor.java:102)
>         at 
> org.apache.drill.exec.store.plan.rule.PluginConverterRule.matches(PluginConverterRule.java:64)
>         at 
> org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:263)
>         at 
> org.apache.calcite.plan.volcano.VolcanoRuleCall.match(VolcanoRuleCall.java:247)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.fireRules(VolcanoPlanner.java:1566)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1840)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:848)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:864)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:92)
>         at 
> org.apache.calcite.rel.AbstractRelNode.onRegister(AbstractRelNode.java:329)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1701)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:848)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:864)
>         at 
> org.apache.calcite.plan.volcano.VolcanoPlanner.changeTraits(VolcanoPlanner.java:531)
>         at 
> org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:324)
>         at 
> org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:405)
>         at 
> org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:351)
>         at 
> org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:245)
>         at 
> org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:308)
>         at 
> org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:173)
>         at 
> org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:283)
>         at 
> org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:163)
>         at 
> org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:128)
>         at 
> org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:93)
>         at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:593)
>         at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:274)
>         ... 3 common frames omitted {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to