[ 
https://issues.apache.org/jira/browse/DRILL-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479379#comment-17479379
 ] 

ASF GitHub Bot commented on DRILL-8056:
---------------------------------------

cgivre commented on a change in pull request #2401:
URL: https://github.com/apache/drill/pull/2401#discussion_r788783715



##########
File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
##########
@@ -43,6 +44,10 @@
     <#else>
       <a id="enabled" class="btn btn-success text-white">Enable</a>
     </#if>
+    <#if model.getType() == "HttpStoragePluginConfig" >
+    <! -- TODO Also check to see whether the plugin uses OAuth or not -->

Review comment:
       Fixed.  The button now only appears when the plugin uses OAuth.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Add OAuth2 Support for HTTP Rest Plugin
> ---------------------------------------
>
>                 Key: DRILL-8056
>                 URL: https://issues.apache.org/jira/browse/DRILL-8056
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Other
>    Affects Versions: 1.19.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.20.0
>
>
> Many enterprise platforms use OAuth2 for authentication and authorization.  
> This pull request allows Drill to authenticate with external APIs that use 
> OAuth2 and query these data sources.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to