[ 
https://issues.apache.org/jira/browse/DRILL-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482800#comment-17482800
 ] 

ASF GitHub Bot commented on DRILL-8114:
---------------------------------------

luocooong commented on a change in pull request #2436:
URL: https://github.com/apache/drill/pull/2436#discussion_r793142009



##########
File path: 
contrib/format-iceberg/src/main/java/org/apache/drill/exec/store/iceberg/plan/IcebergPluginImplementor.java
##########
@@ -144,14 +141,18 @@ public boolean splitProject(Project project) {
 
   @Override
   public boolean canImplement(Project project) {
-    return true;
+    return hasIcebergGroupScan(project);
   }
 
   @Override
   public GroupScan getPhysicalOperator() {
     return groupScan;
   }
 
+  private boolean hasIcebergGroupScan(RelNode node) {

Review comment:
       It seems that this validation rule also applies to #2389?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Prevent applying Iceberg project on non-Iceberg tables
> ------------------------------------------------------
>
>                 Key: DRILL-8114
>                 URL: https://issues.apache.org/jira/browse/DRILL-8114
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.20.0
>            Reporter: Vova Vysotskyi
>            Assignee: Vova Vysotskyi
>            Priority: Blocker
>             Fix For: 1.20.0
>
>
> When running complex queries on non-Iceberg tables, some Iceberg rules are 
> still applied, so it might cause whole the query to fail



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to