[
https://issues.apache.org/jira/browse/DRILL-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484070#comment-17484070
]
ASF GitHub Bot commented on DRILL-8111:
---------------------------------------
luocooong commented on a change in pull request #2433:
URL: https://github.com/apache/drill/pull/2433#discussion_r794995709
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java
##########
@@ -69,6 +60,85 @@
@JsonProperty
private final String method;
+ public HttpPaginatorConfig(HttpPaginatorConfigBuilder builder) {
+ this.limitParam = builder.limitParam;
+ this.offsetParam = builder.offsetParam;
+ this.pageParam = builder.pageParam;
+ this.pageSizeParam = builder.pageSizeParam;
+ this.pageSize = builder.pageSize;
+ this.maxRecords = builder.maxRecords;
+ this.method = builder.method;
+ }
+
+ public static HttpPaginatorConfigBuilder builder() {
+ return new HttpPaginatorConfigBuilder();
+ }
+
+ public String limitParam() {
+ return this.limitParam;
+ }
+
+ public String offsetParam() {
+ return this.offsetParam;
+ }
+
+ public String pageParam() {
+ return this.pageParam;
+ }
+
+ public String pageSizeParam() {
+ return this.pageSizeParam;
+ }
+
+ public int pageSize() {
+ return this.pageSize;
+ }
+
+ public int maxRecords() {
+ return this.maxRecords;
+ }
+
+ public String method() {
+ return this.method;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ HttpPaginatorConfig that = (HttpPaginatorConfig) o;
+ return pageSize == that.pageSize
+ && maxRecords == that.maxRecords
+ && Objects.equals(limitParam, that.limitParam)
+ && Objects.equals(offsetParam, that.offsetParam)
+ && Objects.equals(pageParam, that.pageParam)
+ && Objects.equals(pageSizeParam, that.pageSizeParam)
+ && Objects.equals(method, that.method);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(limitParam, offsetParam, pageParam, pageSizeParam,
+ pageSize, maxRecords, method);
+ }
+
+ @Override
+ public String toString() {
Review comment:
@paul-rogers Thanks for the review, this pull request was created by
Vova. Anyway, it looks like we'll be able to merge the request soon..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove lombok usage
> -------------------
>
> Key: DRILL-8111
> URL: https://issues.apache.org/jira/browse/DRILL-8111
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.20.0
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: 1.20.0
>
>
> See https://lists.apache.org/thread/gdv21h4m9omoqojhbpc4pcxtmyoqwrm6 for
> details.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
