[ 
https://issues.apache.org/jira/browse/DRILL-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484297#comment-17484297
 ] 

ASF GitHub Bot commented on DRILL-8118:
---------------------------------------

cgivre commented on a change in pull request #2442:
URL: https://github.com/apache/drill/pull/2442#discussion_r795120999



##########
File path: 
contrib/storage-mongo/src/main/resources/bootstrap-storage-plugins.json
##########
@@ -3,6 +3,7 @@
     "mongo" : {
       "type":"mongo",
       "connection":"mongodb://localhost:27017/",
+      "allowDiskUse": false,

Review comment:
       @luocooong, Thanks for the quick review.  The deserialization should 
only be affected if you remove config parameters. This defaults to `false`, so 
if the user doesn't do anything, Drill's behavior stays the same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Add Option to Allow Disk Use on Mongo Queries
> ---------------------------------------------
>
>                 Key: DRILL-8118
>                 URL: https://issues.apache.org/jira/browse/DRILL-8118
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - MongoDB
>    Affects Versions: 1.19.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.20.0
>
>
> MongoDB has a strange feature (?) whereby queries which use more than 100MB 
> of memory will by default fail.  Mongo allows the user to specify whether 
> they want the query to spill to disk which allows larger queries but at a 
> performance cost.
> This minor PR adds the ability for a user to specify whether they want this 
> option included in Mongo queries.  This only affects aggregate queries in 
> Mongo. 
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to