[
https://issues.apache.org/jira/browse/DRILL-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485768#comment-17485768
]
ASF GitHub Bot commented on DRILL-7994:
---------------------------------------
vvysotskyi commented on a change in pull request #2447:
URL: https://github.com/apache/drill/pull/2447#discussion_r797570750
##########
File path: .travis.yml
##########
@@ -50,41 +50,43 @@ before_install:
- git fetch --unshallow
# Install libraries required for protobuf generation
- |
- if [ $PHASE = "build_checkstyle_protobuf" ]; then \
- sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev
libsasl2-dev cmake libcppunit-dev checkinstall && \
- pushd .. && \
- if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then \
- sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; \
- else \
- wget
https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip
&& \
- unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && \
- ./configure && sudo make && sudo checkinstall -y && \
- if [ ! -d $HOME/protobuf ]; then \
- mkdir -p $HOME/protobuf; \
- fi && \
- mv protobuf_3.16.1* $HOME/protobuf/ && popd; \
- fi && \
- sudo ldconfig && popd; \
+ if [ $PHASE = "build_checkstyle_protobuf" ]; then
+ sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev
libsasl2-dev cmake libcppunit-dev checkinstall &&
+ pushd .. &&
+ if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then
+ sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*;
+ else
+ wget
https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip
&&
+ unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 &&
+ ./configure && sudo make && sudo checkinstall -y &&
+ if [ ! -d $HOME/protobuf ]; then
+ mkdir -p $HOME/protobuf;
+ fi &&
+ mv protobuf_3.16.1* $HOME/protobuf/ && popd;
+ fi &&
+ sudo ldconfig && popd;
fi
install:
# For tests phase runs unit tests
# For protobuf phase: builds Drill project, performs license checkstyle goal
and regenerates Java and C++ Protobuf files
- |
- if [ $PHASE = "tests" ]; then \
- mvn install --batch-mode --no-transfer-progress \
-
-DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest";
\
- elif [ $PHASE = "build_checkstyle_protobuf" ]; then \
- MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --no-transfer-progress
-Drat.skip=false -Dlicense.skip=false --batch-mode
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
-DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \
- pushd protocol && mvn process-sources -P proto-compile && popd && \
- mkdir contrib/native/client/build && pushd contrib/native/client/build
&& /usr/bin/cmake -G "Unix Makefiles" .. && make cpProtobufs && popd; \
+ if [ $PHASE = "tests" ]; then
+ echo Selecting parallel GC to minimise peak mem usage.
Review comment:
Please avoid adding such comments in the ci output, they might confuse
people that trying to figure out why their tests failing.
##########
File path: .travis.yml
##########
@@ -50,41 +50,43 @@ before_install:
- git fetch --unshallow
# Install libraries required for protobuf generation
- |
- if [ $PHASE = "build_checkstyle_protobuf" ]; then \
- sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev
libsasl2-dev cmake libcppunit-dev checkinstall && \
- pushd .. && \
- if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then \
- sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*; \
- else \
- wget
https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip
&& \
- unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 && \
- ./configure && sudo make && sudo checkinstall -y && \
- if [ ! -d $HOME/protobuf ]; then \
- mkdir -p $HOME/protobuf; \
- fi && \
- mv protobuf_3.16.1* $HOME/protobuf/ && popd; \
- fi && \
- sudo ldconfig && popd; \
+ if [ $PHASE = "build_checkstyle_protobuf" ]; then
+ sudo apt-get install -y libboost-all-dev libzookeeper-mt-dev
libsasl2-dev cmake libcppunit-dev checkinstall &&
+ pushd .. &&
+ if [ -f $HOME/protobuf/protobuf_3.16.1* ]; then
+ sudo dpkg -i $HOME/protobuf/protobuf_3.16.1*;
+ else
+ wget
https://github.com/protocolbuffers/protobuf/releases/download/v3.16.1/protobuf-java-3.16.1.zip
&&
+ unzip protobuf-java-3.16.1.zip && pushd protobuf-3.16.1 &&
+ ./configure && sudo make && sudo checkinstall -y &&
+ if [ ! -d $HOME/protobuf ]; then
+ mkdir -p $HOME/protobuf;
+ fi &&
+ mv protobuf_3.16.1* $HOME/protobuf/ && popd;
+ fi &&
+ sudo ldconfig && popd;
fi
install:
# For tests phase runs unit tests
# For protobuf phase: builds Drill project, performs license checkstyle goal
and regenerates Java and C++ Protobuf files
- |
- if [ $PHASE = "tests" ]; then \
- mvn install --batch-mode --no-transfer-progress \
-
-DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest";
\
- elif [ $PHASE = "build_checkstyle_protobuf" ]; then \
- MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --no-transfer-progress
-Drat.skip=false -Dlicense.skip=false --batch-mode
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
-DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true && \
- pushd protocol && mvn process-sources -P proto-compile && popd && \
- mkdir contrib/native/client/build && pushd contrib/native/client/build
&& /usr/bin/cmake -G "Unix Makefiles" .. && make cpProtobufs && popd; \
+ if [ $PHASE = "tests" ]; then
+ echo Selecting parallel GC to minimise peak mem usage.
+ MAVEN_OPTS="-XX:+UseParallelGC"
Review comment:
Can we use the same GC as for regular Drill runs, so tests will be
closer to the real envs? If not, why don't use UseParNewGC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Dependency version updates for severe vulnerabilities
> -----------------------------------------------------
>
> Key: DRILL-7994
> URL: https://issues.apache.org/jira/browse/DRILL-7994
> Project: Apache Drill
> Issue Type: Task
> Components: Security
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: James Turton
> Priority: Blocker
> Fix For: 1.20.0
>
> Attachments: dependency-check-report.html
>
>
> Dependency updates based on severe vulnerabilities reported by the OWASP
> dependency check.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
