[
https://issues.apache.org/jira/browse/DRILL-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499595#comment-17499595
]
ASF GitHub Bot commented on DRILL-8140:
---------------------------------------
cgivre commented on a change in pull request #2474:
URL: https://github.com/apache/drill/pull/2474#discussion_r816846371
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpApiConfig.java
##########
@@ -271,6 +282,10 @@ private HttpApiConfig(HttpApiConfig.HttpApiConfigBuilder
builder) {
// Accept either basic or none. The default is none.
this.authType = StringUtils.defaultIfEmpty(builder.authType, "none");
this.postBody = builder.postBody;
+
+ // Default to query string to avoid breaking changes
+ this.postParameterLocation =
StringUtils.defaultIfEmpty(builder.postParameterLocation.trim().toLowerCase(),
QUERY_STRING_POST_LOCATION);
Review comment:
@luocooong I addressed all your comments and updated the documentation.
This should be ready to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add JSON Post Body to HTTP Rest Storage Plugin
> ----------------------------------------------
>
> Key: DRILL-8140
> URL: https://issues.apache.org/jira/browse/DRILL-8140
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: Future
>
>
> Some APIs require information be sent as a JSON post body. This PR enables
> that.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
