[
https://issues.apache.org/jira/browse/DRILL-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504086#comment-17504086
]
ASF GitHub Bot commented on DRILL-8156:
---------------------------------------
jnturton commented on a change in pull request #2491:
URL: https://github.com/apache/drill/pull/2491#discussion_r823462959
##########
File path: Dockerfile
##########
@@ -56,17 +56,26 @@ RUN VERSION=$(mvn -q -Dexec.executable=echo
-Dexec.args='${project.version}' --n
# Set the BASE_IMAGE build arg when you invoke docker build.
FROM $BASE_IMAGE
-ENV DRILL_HOME=/opt/drill DRILL_USER=drilluser
+ENV DRILL_HOME=/opt/drill
+ENV DRILL_USER=drilluser
+ENV DRILL_USER_HOME=/var/lib/drill
+ENV DRILL_LOG_DIR=$DRILL_USER_HOME/log
+ENV DATA_VOL=/data
-RUN mkdir $DRILL_HOME
+RUN mkdir $DRILL_HOME $DATA_VOL
+
+COPY --from=build /opt/drill $DRILL_HOME
RUN groupadd -g 999 $DRILL_USER \
- && useradd -r -u 999 -g $DRILL_USER $DRILL_USER -m -d /var/lib/drill \
- && chown -R $DRILL_USER: $DRILL_HOME
+ && useradd -r -u 999 -g $DRILL_USER $DRILL_USER -m -d $DRILL_USER_HOME \
+ && chown $DRILL_USER: $DATA_VOL \
+ && chmod -R +r $DRILL_HOME
Review comment:
@vvysotskyi it introduces a dependency on something called BuildKit,
output from my attempt to use this flag:
```
COPY --from=build --chmod=0755 /opt/drill $DRILL_HOME
the --chmod option requires BuildKit. Refer to
https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit
enabled
```
Do you still think it's worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Declare and chown a /data VOLUME in the Drill Dockerfile
> --------------------------------------------------------
>
> Key: DRILL-8156
> URL: https://issues.apache.org/jira/browse/DRILL-8156
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.20.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
>
> Some users of embedded Drill in Docker want to use a Docker volume with
> Drill, particularly for Drill's persistent local storage so that Drill
> configuration can persist across container launches. Because Drill no longer
> runs as root in the Docker container as of 1.20, these users now need a
> mountpoint inside that container that has been chowned to drilluser.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
