[ 
https://issues.apache.org/jira/browse/DRILL-8168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506913#comment-17506913
 ] 

ASF GitHub Bot commented on DRILL-8168:
---------------------------------------

jnturton commented on pull request #2495:
URL: https://github.com/apache/drill/pull/2495#issuecomment-1068003565


   @cgivre I updated the docs to describe the `userName` property supported by 
/query.json (even though this PR did not introduce it, just fixes a bug 
relating to it).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Duplicated attempt to apply inbound impersonation in the REST API
> -----------------------------------------------------------------
>
>                 Key: DRILL-8168
>                 URL: https://issues.apache.org/jira/browse/DRILL-8168
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.20.0
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Major
>             Fix For: Future
>
>
> When a payload that includes the {{userName}} property is POSTed to 
> /query.json Drill will check for authorisation and, if that's found, replace 
> the username on its UserSession with that of the impersonated user.  When a 
> subsequent request arrives Drill will again attempt the same replacement, but 
> now starting from a UserSession user that has already been changed to the 
> impersonated user.  This is liable to fail when the impersonated user is not 
> authorised to impersonate themself.
> This has never been an issue in the Web UI because it only presents an 
> opportunity for impersonation when impersonation is enabled _and_ {_}authn is 
> disabled{_}.  When authn is disabled, there is no persistent UserSession so 
> it is okay to repeat the username replacement for every request to 
> /query.json.  This leaves people who have both impersonation and authn 
> enabled in the lurch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to