[
https://issues.apache.org/jira/browse/DRILL-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530671#comment-17530671
]
ASF GitHub Bot commented on DRILL-8035:
---------------------------------------
vvysotskyi commented on code in PR #2527:
URL: https://github.com/apache/drill/pull/2527#discussion_r862758310
##########
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java:
##########
@@ -240,7 +240,7 @@ public Class<?> getImplementationClass(
Map<String, Pair<byte[], ClassNode>> classesToMerge = Maps.newHashMap();
for (byte[] clazz : implementationClasses) {
totalBytecodeSize += clazz.length;
- final ClassNode node = AsmUtil.classFromBytes(clazz,
ClassReader.EXPAND_FRAMES);
+ ClassNode node = AsmUtil.classFromBytes(clazz,
ClassReader.SKIP_FRAMES);
Review Comment:
We use `ClassWriter#COMPUTE_FRAMES` for class writer, so according to the
docs, `ClassReader.SKIP_FRAMES` is useful to avoid visiting frames that will be
ignored and recomputed from the scratch. I had to set it in this PR because
Janino has changed something in its bytecode, so it fails with the
`ClassReader.EXPAND_FRAMES` flag.
> Update Janino to 3.1.7 version
> ------------------------------
>
> Key: DRILL-8035
> URL: https://issues.apache.org/jira/browse/DRILL-8035
> Project: Apache Drill
> Issue Type: Wish
> Components: 1.19
> Affects Versions: Future
> Reporter: Vitalii Diravka
> Assignee: Vova Vysotskyi
> Priority: Major
>
> Drill uses 3.0.11 Janino version. The latest one is
> [3.1.7|https://mvnrepository.com/artifact/org.codehaus.janino/janino/3.1.7]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
