[
https://issues.apache.org/jira/browse/DRILL-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534440#comment-17534440
]
ASF GitHub Bot commented on DRILL-8219:
---------------------------------------
jnturton commented on PR #2542:
URL: https://github.com/apache/drill/pull/2542#issuecomment-1122604719
> LGTM +1
> This is really a minor update, but is it worth adding a unit test? We can
skip it if it is a major hassle.
I think a unit test would need a new DB2 testcontainer or a mocked JDBC
Connection that returns a null like DB2 does. The cost/benefit of doing those
to exercise a null test doesn't look good to me, but there may be some tricks I
don't know.
> Handle null catalog names returned by DB2 in storage-jdbc
> ---------------------------------------------------------
>
> Key: DRILL-8219
> URL: https://issues.apache.org/jira/browse/DRILL-8219
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
> Affects Versions: 1.20.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 2.0.0
>
>
> DB2 is another DBMS in which clients must connect to a named database, not
> just to the DBMS. A JDBC connection that does the same will receive a single
> record containing a null string from a call to
> Connection::getMetaData::getCatalogs. We need to ignore such a record in
> order to query DB2 correctly.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
