[
https://issues.apache.org/jira/browse/DRILL-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536193#comment-17536193
]
ASF GitHub Bot commented on DRILL-8211:
---------------------------------------
jnturton commented on code in PR #2535:
URL: https://github.com/apache/drill/pull/2535#discussion_r871526487
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushRowKeyJoinToScanRule.java:
##########
@@ -463,8 +463,9 @@ private static boolean isRowKeyColumn(int index, RelNode
rel) {
}
// If no exprs present in projection the column index remains the same
in the child.
// Otherwise, the column index is the `RexInputRef` index.
- if (curRel != null && curRel instanceof DrillProjectRel) {
- List<RexNode> childExprs = curRel.getChildExps();
+ if (curRel instanceof DrillProjectRel) {
Review Comment:
I didn't realise that an `instanceof` already provides a null check, nice.
> Replace deprecated RelNode.getChildExps with Project.getProjects
> ----------------------------------------------------------------
>
> Key: DRILL-8211
> URL: https://issues.apache.org/jira/browse/DRILL-8211
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
>
> In the newer Calcite version RelNode.getChildExps was removed, so replacing
> it with Project.getProjects
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
