[
https://issues.apache.org/jira/browse/DRILL-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536803#comment-17536803
]
ASF GitHub Bot commented on DRILL-8214:
---------------------------------------
vvysotskyi commented on code in PR #2538:
URL: https://github.com/apache/drill/pull/2538#discussion_r872651152
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectIntoScanRule.java:
##########
@@ -46,16 +46,28 @@
public class DrillPushProjectIntoScanRule extends RelOptRule {
public static final RelOptRule INSTANCE =
new DrillPushProjectIntoScanRule(LogicalProject.class,
- EnumerableTableScan.class,
+ DirPrunedTableScan.class,
"DrillPushProjectIntoScanRule:enumerable") {
@Override
protected boolean skipScanConversion(RelDataType projectRelDataType,
TableScan scan) {
- // do not allow skipping conversion of EnumerableTableScan to
DrillScanRel if rule is applicable
+ // do not allow skipping conversion of DirPrunedTableScan to
DrillScanRel if rule is applicable
return false;
}
};
+ public static final RelOptRule LOGICAL_INSTANCE =
+ new DrillPushProjectIntoScanRule(LogicalProject.class,
+ LogicalTableScan.class,
+ "DrillPushProjectIntoScanRule:none") {
+
+ @Override
+ protected boolean skipScanConversion(RelDataType projectRelDataType,
TableScan scan) {
+ // do not allow skipping conversion of EnumerableTableScan to
DrillScanRel if rule is applicable
Review Comment:
Thanks, fixed.
> Replace EnumerableTableScan usage with LogicalTableScan
> -------------------------------------------------------
>
> Key: DRILL-8214
> URL: https://issues.apache.org/jira/browse/DRILL-8214
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
>
> Newer Calcite version returns LogicalTableScan instead of EnumerableTableScan
> in RelOptTableImpl, so Drill shouldn't rely on this class also and
> LogicalTableScan where possible to avoid planning issues.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
