[ 
https://issues.apache.org/jira/browse/DRILL-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541885#comment-17541885
 ] 

ASF GitHub Bot commented on DRILL-8149:
---------------------------------------

pjfanning commented on PR #2483:
URL: https://github.com/apache/drill/pull/2483#issuecomment-1136941768

   > @pjfanning Is it possible to resolve the above conflicts and do a rebase 
on the master branch? Because I'm ready to merge this good feature.
   
   I've resolved the merge conflict but am leaving this in draft because I 
still need to add test coverage.




> format-excel plugin needs to support POI IOUtils byte array overrides to 
> support big files
> ------------------------------------------------------------------------------------------
>
>                 Key: DRILL-8149
>                 URL: https://issues.apache.org/jira/browse/DRILL-8149
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Data Types
>    Affects Versions: 1.19.0
>            Reporter: PJ Fanning
>            Priority: Major
>
> [https://poi.apache.org/components/configuration.html] - see 
> [org.apache.poi.util.IOUtils.setByteArrayMaxOverride(int 
> maxOverride)|https://poi.apache.org/apidocs/5.0/org/apache/poi/util/IOUtils.html#setByteArrayMaxOverride-int-]
> Core POI code tries to set limits on resource allocations. 
> excel-streaming-reader may not be as heavily affected by these settings 
> because it only used parts of the core POI codebase.
> POI 5.2.1 (due in next few weeks) fixes a few issues but there is some 
> evidence that core POI users are hitting issues when loading large files and 
> having to set  the byte array max override setting.
> I can do some testing of the format-excel plugin to see if it can hit these 
> issues with large files.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to