[
https://issues.apache.org/jira/browse/DRILL-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543925#comment-17543925
]
PJ Fanning commented on DRILL-8240:
-----------------------------------
The issue is that Apache Hive code uses a class from log4j-api jar but Drill
does not include log4j-api jar as a dependency when it uses Apache Hive. So
far, the solution is for Drill to have a copy of the log4j class that Hive
needs. This java file needs to be kept up to date - we upgraded Log4j during
the Log4j panic at the tirn of this year - but never upgraded the java file.
I believe that Drill should not be copying log4j classes like this and that it
should include the log4j-api jar as a dependency when using Apache Hive. If
Drill team insists on not adding this dependency, then we are stuck with having
to merge in all the changes that happen to the Java file.
> Revisit clone of log4j Strings class
> ------------------------------------
>
> Key: DRILL-8240
> URL: https://issues.apache.org/jira/browse/DRILL-8240
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Hive
> Affects Versions: 1.20.1
> Reporter: PJ Fanning
> Priority: Major
>
> See https://issues.apache.org/jira/browse/DRILL-8044 for background.
> The code added there is now out of date. After the log4j panic late last
> year, 5 commits were made to modify the real log4j class and these are
> missing from the Drill copy.
> Compare
> https://github.com/apache/logging-log4j2/commits/rel/2.17.2/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java
> to
> https://github.com/apache/logging-log4j2/commits/rel/2.14.1/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java
> The Drill copy is based on Log4J 2.14.1. Every commit in 2021 and 2022 is
> missing from the Drill copy.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
