[
https://issues.apache.org/jira/browse/DRILL-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544138#comment-17544138
]
ASF GitHub Bot commented on DRILL-8113:
---------------------------------------
vvysotskyi commented on code in PR #2565:
URL: https://github.com/apache/drill/pull/2565#discussion_r885222575
##########
pom.xml:
##########
@@ -3988,13 +3988,13 @@
<jdk>[9,)</jdk>
</activation>
<properties>
+ <maven.compiler.release>8</maven.compiler.release>
<junit.args>
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens java.base/sun.nio.ch=ALL-UNNAMED
- --add-opens java.security.jgss/sun.security.krb5=ALL-UNNAMED
Review Comment:
It is added not only for tests:
https://github.com/apache/drill/blob/master/distribution/src/main/resources/drill-config.sh#L317
As I mentioned above, Drill should also work fine with changed
maven.compiler.release property to 17 version.
> Support building with a JDK 8 target using newer JDKs
> -----------------------------------------------------
>
> Key: DRILL-8113
> URL: https://issues.apache.org/jira/browse/DRILL-8113
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.19.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Trivial
> Fix For: 1.20.2
>
>
> Currently, adding
>
> {code:java}
> <maven.compiler.release>8</maven.compiler.release>{code}
>
> to pom.xml in order to build Drill for JDK 8 under JDK 11 will produce build
> errors relating to the package {{{}sun.security.jgss{}}}. This should be
> rectified.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
