[
https://issues.apache.org/jira/browse/DRILL-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571004#comment-17571004
]
ASF GitHub Bot commented on DRILL-8235:
---------------------------------------
jnturton commented on code in PR #2585:
URL: https://github.com/apache/drill/pull/2585#discussion_r929111001
##########
contrib/native/client/patches/zookeeper-3.4.6-x64.patch:
##########
@@ -1,163 +0,0 @@
-From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001
Review Comment:
I think the .gitignore is working properly already because all of our
previous commits have left zookeeper-3.4.6-x64.patch in peace. How about we do
it this way? If this PR wants to delete the patch then it should simultaneously
update readme.win.txt loosely saying "ZooKeeper 3.4.6 is ancient, ZooKeeper
3.5.7 is current and does not need any patch to build on Windows so the patch
remains in the Git history only". Alternatively, we revert the deletion here
and carry the cruft a bit longer.
+1 one from me otherwise.
> Add Storage Plugin for Google Sheets
> ------------------------------------
>
> Key: DRILL-8235
> URL: https://issues.apache.org/jira/browse/DRILL-8235
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.20.1
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 2.0.0
>
>
> Google Sheets is a very commonly used data source among business users.
> Presto and other query engines do include integrations with Google Sheets and
> so it would be useful for Drill to add this functionality.
> The proposed plugin supports both reading and writing to Google Sheets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
