[ 
https://issues.apache.org/jira/browse/DRILL-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571164#comment-17571164
 ] 

ASF GitHub Bot commented on DRILL-8268:
---------------------------------------

jnturton commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r929457387


##########
exec/vector/pom.xml:
##########
@@ -25,7 +25,7 @@
     <groupId>org.apache.drill.exec</groupId>
     <version>2.0.0-SNAPSHOT</version>
   </parent>
-  <artifactId>vector</artifactId>
+  <artifactId>drill-vector</artifactId>

Review Comment:
   @luocooong it is only the artifactId that is inconsistent here. The name of 
`Drill : Exec : Vectors` already looks good to me. So I'll revert this. I agree 
that the renaming could not be backported like the rest of the changes here are 
meant to be.





> Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default
> ---------------------------------------------------------------------------
>
>                 Key: DRILL-8268
>                 URL: https://issues.apache.org/jira/browse/DRILL-8268
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.20.1
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Major
>             Fix For: 1.20.2
>
>
> # New exclusions of reload4j, slf4j-reload4j are required in the Hadoop 2 
> profile, probably due to the upgrade of Hadoop from 2.10.1 to 2.10.2.
>  # We remove the netty-all metapackage which entered the dependency tree with 
> the change introducing the Netty bom bringing many uneeded libs with it.
>  # The heap memory usage limiting logic in the REST server becomes disabled 
> by default since REST query results are streamed these days. This change aims 
> to let the Java GC now do its job without interference and if that results in 
> OOM under a constant load then there is good evidence for a heap leak which 
> must be tracked down and completely resolved anyway, not mitigated or "swept 
> under a rug".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to