[ 
https://issues.apache.org/jira/browse/DRILL-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574512#comment-17574512
 ] 

ASF GitHub Bot commented on DRILL-7523:
---------------------------------------

vvysotskyi commented on code in PR #2602:
URL: https://github.com/apache/drill/pull/2602#discussion_r936273407


##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlSelectBuilder.java:
##########
@@ -90,8 +91,14 @@ public SqlSelectBuilder fetch(SqlNode fetch) {
     return this;
   }
 
+  public SqlSelectBuilder hints(SqlNodeList hints) {

Review Comment:
   In the future, I think we will use this functionality to provide more 
flexibility for configuring the planning process.





> Update Calcite to 1.31.0
> ------------------------
>
>                 Key: DRILL-7523
>                 URL: https://issues.apache.org/jira/browse/DRILL-7523
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.17.0
>            Reporter: Vova Vysotskyi
>            Assignee: Vova Vysotskyi
>            Priority: Major
>             Fix For: Future
>
>
> Upgrade to Calcite 1.31 version.
> Also, there are some fixes that may help to avoid specific commit for 
> CALCITE-3121.
> As discussed in CALCITE-2223, there were made additional changes for fixing 
> this issue, so we should check whether we can remove the workaround made in 
> DRILL-6212.
> Incorporate with changes made in 
> https://issues.apache.org/jira/browse/CALCITE-3774 - remove overriding 
> {{shouldMergeProject}} and set {{withBloat(int bloat)}} in custom rel builder 
> and investigate whether it would help to remove {{Hook.REL_BUILDER_SIMPLIFY}} 
> hook.
> Additionally, please check whether specific commit with ViewExpander may be 
> removed due to changes made in CALCITE-2441.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to