[
https://issues.apache.org/jira/browse/DRILL-8287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597178#comment-17597178
]
ASF GitHub Bot commented on DRILL-8287:
---------------------------------------
jnturton commented on code in PR #2633:
URL: https://github.com/apache/drill/pull/2633#discussion_r957255881
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpPaginatorConfig.java:
##########
@@ -137,21 +162,28 @@ public String toString() {
.field("pageSize", pageSize)
.field("maxRecords", maxRecords)
.field("method", method)
+ .field("indexParam", indexParam)
+ .field("hasMoreParam", hasMoreParam)
+ .field("nextPageParam", nextPageParam)
.toString();
}
public enum PaginatorMethod {
OFFSET,
- PAGE
+ PAGE,
+ INDEX
}
- private HttpPaginatorConfig(HttpPaginatorConfig.HttpPaginatorBuilder
builder) {
+ /*private HttpPaginatorConfig(HttpPaginatorConfig.HttpPaginatorConfigBuilder
builder) {
Review Comment:
Is this commented out code meant to be included?
> Add Support for Keyset Based Pagination
> ---------------------------------------
>
> Key: DRILL-8287
> URL: https://issues.apache.org/jira/browse/DRILL-8287
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - HTTP
> Affects Versions: 1.20.2
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 2.0.0
>
>
> Some APIs such as HubSpot use values in the result set to indicate whether
> there are additional pages. This PR adds support for this kind of
> pagination. Note that current implementation only works for JSON based APIs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
